Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Tag styles for PageDescription and ResourceCard #1513

Merged

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Sep 12, 2024

Related issue carbon-design-system/carbon-website#4258

image image

Changelog

New

  • Add styles for spacing between multiple children in Resource Cards
  • Add styles for optional Tag inside of PageDescription

Review

https://deploy-preview-1513--gatsby-theme-carbon.netlify.app/components/ResourceCard/#with-tag

https://deploy-preview-1513--gatsby-theme-carbon.netlify.app/components/PageDescription/

@alisonjoseph alisonjoseph requested review from eng618 and a team as code owners September 12, 2024 19:26
@alisonjoseph alisonjoseph requested review from kennylam and tay1orjones and removed request for a team September 12, 2024 19:26
@alisonjoseph alisonjoseph self-assigned this Sep 12, 2024
Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 7:33pm

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit feb5065
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/66e34131c6e95d0009611096
😎 Deploy Preview https://deploy-preview-1513--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for doing this!

@alisonjoseph alisonjoseph merged commit 50125c4 into carbon-design-system:main Sep 12, 2024
8 checks passed
@alisonjoseph alisonjoseph deleted the resource-card-tag branch September 12, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants