Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to validate lint and format #1345

Merged
merged 9 commits into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: release-it

on:
workflow_run:
workflows: ['Validate']
branches: [main]
types:
- completed
push:
branches:
- main
Expand Down
44 changes: 44 additions & 0 deletions .github/workflows/validate-and-build.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Validate

on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
validate-and-build:
runs-on: ubuntu-20.04
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
steps:
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '18'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT

- name: Cache dependencies
uses: actions/cache@v3
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Install dependencies
run: yarn

- name: Validate
run: yarn validate

- name: Build
run: yarn build:prefix
10 changes: 7 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,16 @@
"serve:prefix": "yarn build:prefix && yarn workspace example serve --prefix-paths",
"now-build": "yarn workspace example build",
"format": "prettier --write \"**/*.{css,scss,json,html,yaml,mdx}\"",
"format:ci": "prettier --check \"**/*.{css,scss,json,html,yaml,mdx}\"",
"lint": "eslint . && stylelint \"packages/**/*.scss\"",
"lint:fix": "yarn lint:js && yarn lint:scss",
"lint:js": "eslint . --fix",
"lint:scss": "stylelint \"packages/**/*.scss\" --fix",
"release": "release-it",
"release:pre": "release-it --preRelease=next",
"release:ci": "release-it --ci",
"release:dry": "release-it --dry-run"
"release:dry": "release-it --dry-run",
"validate": "yarn format:ci && yarn lint"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
Expand Down Expand Up @@ -96,9 +100,9 @@
"prettier-config-carbon": "^0.11.0",
"release-it": "^14.14.3",
"release-it-yarn-workspaces": "^2.0.1",
"stylelint": "^15.10.3",
"stylelint": "^13.13.1",
"stylelint-config-recommended-scss": "^4.3.0",
"stylelint-scss": "^5.1.0"
"stylelint-scss": "^3.21.0"
},
"version": "3.1.14",
"packageManager": "yarn@3.3.0"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable import/no-unresolved */
/* eslint-disable import/no-extraneous-dependencies */
import React, { useEffect } from 'react';

import { Information } from '@carbon/icons-react';
Expand Down
16 changes: 0 additions & 16 deletions packages/example/src/pages/components/ArticleCard.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@ description: Usage instructions for the ArticleCard component

<PageDescription>


The `<ArticleCard>` component should generally be used inside of a `<Row>` and
`<Column>` with a `noGutterMdLeft` prop on the `<Column>` to allow it to "hang"
to the left.

</PageDescription>


## Example

<Row>
Expand All @@ -26,7 +24,6 @@ to the left.
href="/"
>


![Dark article layout mockup](/images/Article_06.png)

</ArticleCard>
Expand All @@ -39,7 +36,6 @@ to the left.
actionIcon="arrowRight"
>


![Dark article layout mockup](/images/Article_06.png)

</ArticleCard>
Expand All @@ -51,7 +47,6 @@ to the left.
disabled
>


![Dark article layout mockup](/images/Article_06.png)

</ArticleCard>
Expand All @@ -64,7 +59,6 @@ to the left.
actionIcon="download"
>


![Dark article layout mockup](/images/Article_06.png)

</ArticleCard>
Expand All @@ -80,7 +74,6 @@ to the left.
actionIcon="email"
>


![Dark article layout mockup](/images/Article_06.png)

</ArticleCard>
Expand All @@ -96,14 +89,12 @@ to the left.
disabled
>


![Dark article layout mockup](/images/Article_06.png)

</ArticleCard>
</Column>
</Row>


## Code

```mdx path=components/ArticleCard/ArticleCard.js src=https://github.com/carbon-design-system/gatsby-theme-carbon/tree/main/packages/gatsby-theme-carbon/src/components/ArticleCard
Expand All @@ -119,7 +110,6 @@ to the left.

![Dark article layout mockup](/images/Article_06.png)


</ArticleCard>

</Column>
Expand All @@ -132,7 +122,6 @@ to the left.

![Dark article layout mockup](/images/Article_06.png)


</ArticleCard>

</Column>
Expand All @@ -144,7 +133,6 @@ to the left.

![Dark article layout mockup](/images/Article_06.png)


</ArticleCard>

</Column>
Expand All @@ -157,7 +145,6 @@ to the left.

![Dark article layout mockup](/images/Article_06.png)


</ArticleCard>

</Column>
Expand All @@ -172,7 +159,6 @@ to the left.

![Dark article layout mockup](/images/Article_06.png)


</ArticleCard>

</Column>
Expand All @@ -187,12 +173,10 @@ to the left.

![Dark article layout mockup](/images/Article_06.png)


</ArticleCard>

</Column>
</Row>

```

### Props
Expand Down
4 changes: 0 additions & 4 deletions packages/example/src/pages/components/Caption.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@ description: Usage instructions for the Caption component

<PageDescription>


The `<Caption>` component is typically used below images or videos. They will
default to 4 columns wide unless placed inside a `<Row>` component. In this
case, it will assume the full width of its containing column.

</PageDescription>


## Example

<Title>Normal</Title>
Expand Down Expand Up @@ -49,12 +47,10 @@ case, it will assume the full width of its containing column.
```mdx path=components/Caption/Caption.js src= https://github.com/carbon-design-system/gatsby-theme-carbon/tree/main/packages/gatsby-theme-carbon/src/components/Caption
<Caption fullWidth>


This is a full width caption. With this prop, the caption’s width will be 100%
so it will fill its container.

</Caption>

```

### Props
Expand Down
Loading