Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(leftnavtree): highlight nav item for tabbed pages #1506

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

szinta
Copy link
Contributor

@szinta szinta commented Sep 3, 2024

Closes #1504

When on a tabbed page, highlight the matching nav item in the tree navigation.

Changelog

Changed

  • packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavTree.js

@szinta szinta requested review from eng618 and a team as code owners September 3, 2024 11:02
@szinta szinta requested review from kennylam and annawen1 and removed request for a team September 3, 2024 11:02
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:05am

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit 3fa25fb
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/66d6ecdb8ec45f00089d77f3
😎 Deploy Preview https://deploy-preview-1506--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@szinta
Copy link
Contributor Author

szinta commented Sep 3, 2024

Please check the Navigation page to see the fix in action

@alisonjoseph alisonjoseph merged commit ca64e21 into carbon-design-system:main Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree nav: tabs do not always get highlighted in nav
3 participants