Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches bazel_clang_tidy handling of headers. I found an equivalent change at erenon/bazel_clang_tidy#13, but that was already rejected. Per the criticism, this will result in redundant processing of headers.
The project instead uses
HeaderFilterRegex: ".*"
, but that results in two problems:-k
, errors are repeated when a header is included more than once, which is common.Given the trade-offs and options (including forking), I thought patching was preferable so long as it remains narrow.