Tree is second argument to geef_index_read_tree #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently calling
geef_index.read_tree(index, tree)
raises an Argument Error, it looks like this is due to using the first argument twice in the underlying c code:geef/c_src/index.c
Lines 83 to 87 in 9e9aa23
This PR updates the second call to
enif_get_resource
to use the second argument (argv[0]
)I got to here by following the call stack below:
geef/src/geef_index.erl
Line 123 in 9e9aa23
geef/src/geef_nif.erl
Line 180 in 9e9aa23