Improved FCM Support Supporting both Legacy and OAuth2 Methods #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #326
This is an almost completely rewrite of the FCM plugin.
Now the legacy URLs work providing the Web API Token from the project page. However i've also researched how the json file works and support this too (without all of the overhead of the Google libraries). So the syntax is as follows:
Legacy Mode:
fcm://apikey/target
OAuth2 Mode:
You can point to the
JSON
file generated from the Project page either by path or by web URL (if you're sharing it somewhere on your network) like so:fcm://project_id/target?keyfile=/path/to/keyfile
fcm://project_id/target/target2/targetN/?keyfile=https://user:pass@localhost/web/location
Here is a better overview of what needs to be done to use the new version of this service:
Checklist
flake8
)