Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imgpkg docs with debug example #253

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

seemiller
Copy link
Contributor

imgpkg Issue 130 adds a debug flag to output detailed ggcr logs. The issue also stated to add documentation.

This PR updates the imgpkg documentation to show an example usage of the debug option.

@DennisDenuto
Copy link
Contributor

@seemiller

Thanks for adding documentation around the debug flag!

Step 4 is talking about kbld and deploying onto k8s. So having an imgpkg debug as step 5 seems a little off (the previous step didn't require any imgpkg interaction).

What do you think about moving the debug documentation to the FAQ section? As a 'debugging' section (under security).

We could then reference that debugging section from the basic workflow documentation if we wanted.

Signed-off-by: Nicholas Seemiller <nseemiller@vmware.com>
@seemiller
Copy link
Contributor Author

@DennisDenuto I've updated the docs based on your suggestion

@DennisDenuto
Copy link
Contributor

Thanks @seemiller LGTM

@DennisDenuto DennisDenuto merged commit 856b831 into carvel-dev:develop Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants