Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate homebrew formula during imgpkg release #180

Merged
merged 5 commits into from
Oct 1, 2021
Merged

Generate homebrew formula during imgpkg release #180

merged 5 commits into from
Oct 1, 2021

Conversation

DennisDenuto
Copy link
Contributor

  • The github action will commit to carvel-homebrew repo with the updated
    formula

Authored-by: Dennis Leon leonde@vmware.com

@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e June 28, 2021 17:03 Failure
@DennisDenuto
Copy link
Contributor Author

DennisDenuto commented Jun 28, 2021 •
edited
Loading

  • stop using tags and use commit shas
  • consider inlining the git commit + push action since it gets access to a TOKEN.

An example of what the homebrew Formula looks like. see: DennisDenuto/homebrew-carvel#2

Note:

In addition to the existing assets that are uploaded (binary files) This will also upload compressed archives "zip" of said binary files. (The homebrew Formula will download and extract the zip files instead of referencing the binary files)

Prior to merging in:

This github action requires a PAT that has write access to the vmware-tanzu/homebrew-carvel repo

Under imgpkg's settings / Secrets / Repository Secrets -->

HOMEBREW_TOKEN = PAT

@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e June 28, 2021 17:55 Inactive
@DennisDenuto DennisDenuto mentioned this pull request Jun 30, 2021
Open
@DennisDenuto DennisDenuto self-assigned this Jul 7, 2021
@DennisDenuto DennisDenuto mentioned this pull request Jul 22, 2021
Open
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e July 26, 2021 23:19 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e July 26, 2021 23:20 Failure
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e July 27, 2021 00:05 Inactive
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e July 27, 2021 00:05 Inactive
@DennisDenuto DennisDenuto marked this pull request as ready for review July 27, 2021 00:11
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e July 27, 2021 00:23 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e July 27, 2021 00:23 Failure
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e July 27, 2021 00:31 Inactive
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e July 27, 2021 00:31 Inactive
@DennisDenuto DennisDenuto marked this pull request as draft August 24, 2021 22:26
@DennisDenuto
Copy link
Contributor Author

Going to pivot and change away from goreleaser generating the homebrew file and instead using bash.

Main reason being that goreleaser relies on 'zip' artifacts being uploaded to use in the homebrew file.

In addition to also uploading binary files, having zip equivalents will add complexity down-the-line when we decide to sign and verify our distribution assets.

@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e August 27, 2021 19:36 Failure
@DennisDenuto DennisDenuto marked this pull request as ready for review August 27, 2021 19:37
@DennisDenuto DennisDenuto mentioned this pull request Sep 3, 2021
Merged
@DennisDenuto DennisDenuto marked this pull request as draft September 9, 2021 22:30
@DennisDenuto
Copy link
Contributor Author

DennisDenuto commented Sep 9, 2021 •
edited
Loading

This PR is going to change to instead update a metadata file in carvel-release-scripts repo

See the corresponding PR in that repo here: carvel-dev/release-scripts#1

Moving this PR into draft for now...

@DennisDenuto DennisDenuto marked this pull request as ready for review September 24, 2021 23:23
@DennisDenuto
Copy link
Contributor Author

@cppforlife This is ready for a review and ready to merge. I have added the deploy keys to imgpkg and carvel-release-scripts.

Tested on my fork of imgpkg. Resulted in the following commit made to carvel-release-scripts: carvel-dev/release-scripts@9aa30e4

@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e September 24, 2021 23:37 Inactive
@DennisDenuto DennisDenuto temporarily deployed to GCR e2e September 24, 2021 23:37 Inactive
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 1, 2021 20:52 Failure
@DennisDenuto
Generate homebrew formula during imgpkg release
3dbe6c9 
- The github action will commit to carvel-homebrew repo with the updated
formula

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Inline github action git commit+push
ffe6a52 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
split homebrew to separate job
a45e313 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Use bash instead of goreleaser to generate homebrew formula
1dba910 
- this avoids having to upload a 'zip' file since generating homebrew
formulas with goreleaser requires an archive and doesn't allow providing
standalone binaries

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Update carvel-release-scripts with metadata file
395cfa5 
- carvel-release-scripts will use the release yaml to generate the
associated assets (such as the homebrew formula) and is responsible to
updating the various distribution channels from it.
- Add ssh-key when checking out carvel-release-scripts
- Fix typo in repo

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 1, 2021 20:56 Failure
@DennisDenuto DennisDenuto merged commit ff67050 into develop Oct 1, 2021
@DennisDenuto
Copy link
Contributor Author

Merging as discussed with dk

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Oct 1, 2021
@aaronshurley aaronshurley removed the carvel triage This issue has not yet been reviewed for validity label Nov 30, 2021
@joaopapereira joaopapereira deleted the add-homebrew-automation branch March 27, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife cppforlife left review comments

Assignees

@DennisDenuto DennisDenuto

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DennisDenuto @cppforlife @aaronshurley @vmwclabot