Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang to 1.17 #262

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Bump golang to 1.17 #262

merged 1 commit into from
Sep 30, 2021

Conversation

DennisDenuto
Copy link
Contributor

@DennisDenuto DennisDenuto commented Sep 23, 2021 •
edited
Loading

Addresses: #261

Authored-by: Dennis Leon leonde@vmware.com

@DennisDenuto DennisDenuto marked this pull request as draft September 23, 2021 22:54
@DennisDenuto
Copy link
Contributor Author

DennisDenuto commented Sep 23, 2021 •
edited
Loading

Environment tests running on an external registry are failing due to running on pull_request_target They are referencing the github action workflow file still referencing go 1.16 (and not the pushed 1.17)... Need to think about how to handle these type of changes

building / linter / test-gh (local-registry) are passing

@DennisDenuto DennisDenuto marked this pull request as ready for review September 24, 2021 22:12
@DennisDenuto
Copy link
Contributor Author

DennisDenuto commented Sep 24, 2021 •
edited
Loading

@cppforlife In order for dependabot bumps to run on external registries the external registry tests are run against pull_request_target. However that makes testing changes on that workflow file a bit tricky. for e.g. bumping go version.

Not sure how strongly you feel against merging this PR without running external registry tests.... However

The local registry tests are all passing with this golang bump. Merging this PR will allow external tests to run against the bumped golang version on develop (as well as future PRs based on this merged commit too)

@DennisDenuto
Bump golang to 1.17
97398af 
Authored-by: Dennis Leon <leonde@vmware.com>
@cppforlife cppforlife merged commit a9646a3 into develop Sep 30, 2021
@DennisDenuto DennisDenuto deleted the bump-go-1-17 branch September 30, 2021 22:55
seemiller pushed a commit to seemiller/carvel-imgpkg that referenced this pull request Oct 1, 2021
@DennisDenuto @seemiller
Bump golang to 1.17 (carvel-dev#262)
89e862b 
Authored-by: Dennis Leon <leonde@vmware.com>
DennisDenuto added a commit that referenced this pull request Oct 8, 2021
@DennisDenuto
Bump golang to 1.17 (#262)
5c9a049 
Authored-by: Dennis Leon <leonde@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DennisDenuto @cppforlife @vmwclabot