Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verifying certs on windows #265

Merged
merged 7 commits into from
Oct 11, 2021
Merged

Fix verifying certs on windows #265

merged 7 commits into from
Oct 11, 2021

Conversation

DennisDenuto
Copy link
Contributor

@DennisDenuto DennisDenuto commented Oct 4, 2021 •
edited
Loading

Attempts to fix #22

TODO:

  • document how to use custom ca certs with windows root store
  • figure out why windows still has a file handle on the bundle.tar file. TODO in test code
  • confirm ca certs work in an airgapped env
  • investigate if theres any performance cost due to using windows root ca store (I think it downloads ca certs using network)

Authored-by: Dennis Leon leonde@vmware.com

@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 19:21 Failure
@DennisDenuto DennisDenuto changed the title Add windows GH runner Fix verifying certs on windows Oct 4, 2021
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 19:32 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 19:33 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 19:36 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 20:46 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 21:09 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 21:17 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 21:28 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 21:40 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 22:02 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 4, 2021 23:13 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 8, 2021 17:20 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 8, 2021 17:58 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 8, 2021 17:59 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 8, 2021 18:11 Failure
@DennisDenuto
Add windows GH runner
d884ffc 
- use ttl.sh as registry since registry:v2 doesn't have a windows image
- skip tests that cannot run on windows due to image (registry:2) used being available to linux

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Fix git patch applying when using windows
1661821 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
bug fix: Use the windows default ca store if custom ca certs are not …
2bd654f 
…provided by the user

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
test refactor: fix test assertion error
2327fcc 
- use human readable file permissions during test assertion failure message
- swap expected/actual test assertion values

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
test refactor: Stop using docker registry:v2 container to allow runni…
24bda4a 
…ng on windows

- windows doesn't have a registry:v2 image
- run performance tests on windows

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto
Close chunked manifest.json file when reading from tarball
ff19983 
Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e October 8, 2021 18:14 Inactive
@DennisDenuto DennisDenuto temporarily deployed to GCR e2e October 8, 2021 18:14 Inactive
@DennisDenuto DennisDenuto marked this pull request as ready for review October 8, 2021 18:15
cppforlife
cppforlife reviewed Oct 9, 2021
View reviewed changes
test/helpers/assets.go Outdated Show resolved Hide resolved
hack/build.sh Outdated Show resolved Hide resolved
.github/workflows/gh-test.yml Outdated Show resolved Hide resolved
@DennisDenuto
test refactor: Use env var instead of bash arguments
4a05556 
- env var IMGPKG_BINARY_EXT instead of arg
- add new lines

Authored-by: Dennis Leon <leonde@vmware.com>
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e October 11, 2021 16:31 Inactive
@DennisDenuto DennisDenuto temporarily deployed to GCR e2e October 11, 2021 16:31 Inactive
@cppforlife cppforlife merged commit e312057 into develop Oct 11, 2021
@joaopapereira joaopapereira deleted the verify-windows-certs-22 branch October 28, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certs do not verify when running on windows
3 participants
@DennisDenuto @cppforlife @vmwclabot