Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test to build binary locally based on variable value #569

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

kumaritanushree
Copy link
Contributor

Updated test to build binary locally based on variable value. Default it is set to true. If you do not want to build binary through test-all.sh run: export BUILD_LOCAL=false

@kumaritanushree kumaritanushree temporarily deployed to GCR e2e August 28, 2023 08:30 — with GitHub Actions Inactive
@kumaritanushree kumaritanushree temporarily deployed to TanzuNet Registry Dev e2e August 28, 2023 08:30 — with GitHub Actions Inactive
@kumaritanushree kumaritanushree temporarily deployed to GCR e2e August 28, 2023 08:31 — with GitHub Actions Inactive
@kumaritanushree kumaritanushree temporarily deployed to TanzuNet Registry Dev e2e August 28, 2023 08:31 — with GitHub Actions Inactive
hack/test-all.sh Outdated
@@ -2,7 +2,10 @@

set -e -x -u

./hack/build.sh
if [ ${BUILD_LOCAL:-true} == true ]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename it to BUILD_BINARY

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

hack/test-all.sh Outdated
@@ -2,7 +2,10 @@

set -e -x -u

./hack/build.sh
if [ ${BUILD_LOCAL:-true} == true ]; then
echo "build-local"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove echo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -2,7 +2,10 @@

set -e -x -u

./hack/build.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment which says how to use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: kumari tanushree <ktanushree@vmware.com>
@kumaritanushree kumaritanushree temporarily deployed to GCR e2e August 28, 2023 08:44 — with GitHub Actions Inactive
@kumaritanushree kumaritanushree temporarily deployed to TanzuNet Registry Dev e2e August 28, 2023 08:44 — with GitHub Actions Inactive
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 2322c9b into develop Aug 28, 2023
7 checks passed
@joaopapereira joaopapereira deleted the update-optional-build-test branch August 28, 2023 14:45
@kumaritanushree
Copy link
Contributor Author

/cherry-pick v0.36.x

@kumaritanushree
Copy link
Contributor Author

/cherry-pick v0.33.x

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Aug 29, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 29, 2023
Updated test to build binary locally based on variable value
@kumaritanushree
Copy link
Contributor Author

/cherry-pick v0.31.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 29, 2023
Updated test to build binary locally based on variable value
kumaritanushree added a commit that referenced this pull request Aug 29, 2023
Merge pull request #569 from carvel-dev/update-optional-build-test

Updated test to build binary locally based on variable value
kumaritanushree added a commit that referenced this pull request Aug 29, 2023
Merge pull request #569 from carvel-dev/update-optional-build-test

Updated test to build binary locally based on variable value
kumaritanushree added a commit that referenced this pull request Aug 29, 2023
Merge pull request #569 from carvel-dev/update-optional-build-test

Updated test to build binary locally based on variable value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel triage This issue has not yet been reviewed for validity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants