Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added regex and cleanup string algo for repo based tag generator #584

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

rcmadhankumar
Copy link
Contributor

@rcmadhankumar rcmadhankumar commented Oct 9, 2023

Added regex to verify for generating the repo based tags.
Added new unit tests to verify various repo path inputs.

Fixes: #582

Verification:
Created a Package repository that has a package referencing an imgpkg bundle named .dev-pkg-apiextensions-storageversion-cmd-migrate in the artifactory. Copied the package repository with imgpkg copy command along with --repo-based-tags flag. imgpkg bundle was shifted with the tag dev-pkg-apiextensions-storageversion-cmd-migrate and the . in the beginning was removed as expected.

@rcmadhankumar rcmadhankumar had a problem deploying to TanzuNet Registry Dev e2e October 9, 2023 18:18 — with GitHub Actions Failure
@rcmadhankumar rcmadhankumar temporarily deployed to GCR e2e October 9, 2023 18:18 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to TanzuNet Registry Dev e2e October 10, 2023 05:43 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to GCR e2e October 10, 2023 05:43 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to TanzuNet Registry Dev e2e October 11, 2023 04:09 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to TanzuNet Registry Dev e2e October 12, 2023 09:13 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to GCR e2e October 12, 2023 09:13 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to GCR e2e October 13, 2023 09:05 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to TanzuNet Registry Dev e2e October 13, 2023 09:05 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to GCR e2e October 16, 2023 08:29 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to TanzuNet Registry Dev e2e October 16, 2023 08:29 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to TanzuNet Registry Dev e2e October 16, 2023 10:29 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to GCR e2e October 16, 2023 10:29 — with GitHub Actions Inactive
Signed-off-by: rcmadhankumar <rcmadhankumar@gmail.com>
@rcmadhankumar rcmadhankumar temporarily deployed to TanzuNet Registry Dev e2e October 16, 2023 10:34 — with GitHub Actions Inactive
@rcmadhankumar rcmadhankumar temporarily deployed to GCR e2e October 16, 2023 10:34 — with GitHub Actions Inactive
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 6e1758a into carvel-dev:develop Oct 16, 2023
7 checks passed
@sethiyash
Copy link
Contributor

/cherry-pick v0.37.x

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Nov 6, 2023
@sethiyash
Copy link
Contributor

/cherry-pick v0.36.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel triage This issue has not yet been reviewed for validity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Relocating bundle to Google Artifact Registry using --repo-based-tags fails
3 participants