Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go #703

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Bump go #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e6b0bf
Bump go
carvel-bot Sep 18, 2024
f8b7f8e
Bump version of golanci
joaopapereira Sep 18, 2024
44e21cb
Remove test checks that cannot be used
joaopapereira Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.58
version: v1.61
args: -v
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module carvel.dev/imgpkg

go 1.22.6
go 1.23.1

require (
github.com/awslabs/amazon-ecr-credential-helper/ecr-login v0.0.0-20220517224237-e6f29200ae04
Expand Down
21 changes: 0 additions & 21 deletions test/e2e/pull_test_unix_only_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"fmt"
"os"
"path/filepath"
"runtime"
"testing"

"carvel.dev/imgpkg/test/helpers"
Expand All @@ -26,10 +25,6 @@ func TestPull(t *testing.T) {
defer env.Cleanup()

t.Run("Image - copies the User Permission to group and other", func(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test as this is a known issue: https://github.com/carvel-dev/imgpkg/issues/270")
}

folder := env.Assets.CreateTempFolder("simple-image")
env.Assets.AddFileToFolderWithPermissions(filepath.Join(folder, "all-on-user-only"), "some text", 0755)
env.Assets.AddFileToFolderWithPermissions(filepath.Join(folder, "read-on-user-only"), "some text", 0455)
Expand Down Expand Up @@ -70,10 +65,6 @@ func TestPull(t *testing.T) {
})

t.Run("Image - when --preserve-permissions flag is provided it keeps the original permissions on the files", func(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test as this is a known issue: https://github.com/carvel-dev/imgpkg/issues/270")
}

folder := env.Assets.CreateTempFolder("simple-image")
env.Assets.AddFileToFolderWithPermissions(filepath.Join(folder, "all-on-user-only"), "some text", 0755)
env.Assets.AddFileToFolderWithPermissions(filepath.Join(folder, "read-on-user-only"), "some text", 0455)
Expand Down Expand Up @@ -114,10 +105,6 @@ func TestPull(t *testing.T) {
})

t.Run("Image - copies the User Permission to group and other but skips execution because umask is set to 0111", func(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test as this is a known issue: https://github.com/carvel-dev/imgpkg/issues/270")
}

folder := env.Assets.CreateTempFolder("simple-image")
innerFolder := filepath.Join(folder, "some-folder")
env.Assets.AddFolder(innerFolder, 0755)
Expand Down Expand Up @@ -173,10 +160,6 @@ func TestPull(t *testing.T) {
})

t.Run("Bundle - copies the User Permission to group and other", func(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test as this is a known issue: https://github.com/carvel-dev/imgpkg/issues/270")
}

bundleDir := env.BundleFactory.CreateBundleDir(helpers.BundleYAML, helpers.ImagesYAML)
env.Assets.AddFileToFolderWithPermissions(filepath.Join(bundleDir, "all-on-user-only"), "some text", 0755)
env.Assets.AddFileToFolderWithPermissions(filepath.Join(bundleDir, "read-on-user-only"), "some text", 0455)
Expand Down Expand Up @@ -211,10 +194,6 @@ func TestPull(t *testing.T) {
})

t.Run("Bundle - when --preserve-permissions flag is provided it keeps the original permissions on the files", func(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test as this is a known issue: https://https://github.com/carvel-dev/imgpkg/issues/270")
}

bundleDir := env.BundleFactory.CreateBundleDir(helpers.BundleYAML, helpers.ImagesYAML)
env.Assets.AddFileToFolderWithPermissions(filepath.Join(bundleDir, "all-on-user-only"), "some text", 0755)
env.Assets.AddFileToFolderWithPermissions(filepath.Join(bundleDir, "read-on-user-only"), "some text", 0455)
Expand Down
Loading