Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata in imgpkg lock file #132

Merged
merged 12 commits into from
Sep 21, 2021
Merged

Add metadata in imgpkg lock file #132

merged 12 commits into from
Sep 21, 2021

Commits on Sep 20, 2021

  1. Add kbld.carvel.dev/metas in imgpkg lock file

    @cari-lynn @jtigger
    cari-lynn authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    ceef594 View commit details
    Browse the repository at this point in the history

  2. Include image metas in output when provided by imgpkg lock file 

    Signed-off-by: Cari Dean <cdean@pivotal.io>
    @gcheadle-vmware @jtigger
    gcheadle-vmware authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b65ffa2 View commit details
    Browse the repository at this point in the history

  3. Update failing test expectations and fix typos 

    Signed-off-by: Garrett Cheadle <gcheadle@vmware.com>
    @cari-lynn @jtigger
    cari-lynn authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    757d29b View commit details
    Browse the repository at this point in the history

  4. Include 'Type: preresolved' as metadata in imgpkg lock file 

    - exclude metas in imgpkg lock when image is given in digest form
Signed-off-by: Cari Dean <cdean@pivotal.io>
    @gcheadle-vmware @jtigger
    gcheadle-vmware authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    cdfbb52 View commit details
    Browse the repository at this point in the history

  5. Change func to receiver 

    - return err from unmarshalling image lock
    @cari-lynn @jtigger
    cari-lynn authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    92205f2 View commit details
    Browse the repository at this point in the history

  6. Add preresolved meta to image metas from imgpkg lock

    @gcheadle-vmware @jtigger
    gcheadle-vmware authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    8c5a1bc View commit details
    Browse the repository at this point in the history

  7. Add all image meta fields to ImageMeta struct 

    Signed-off-by: Garrett Cheadle <gcheadle@vmware.com>
    @cari-lynn @jtigger
    cari-lynn authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    589b89c View commit details
    Browse the repository at this point in the history

  8. Unmarshal ImageMetas from Lock file in config 

    - Use custom unmarshaler for image metas
- Move Metas from image package to config package
- Rename Metas to ImageMetas
    @cari-lynn @jtigger
    cari-lynn authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    651c3f1 View commit details
    Browse the repository at this point in the history

  9. Add license header :)

    @cari-lynn @jtigger
    cari-lynn authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    424e00b View commit details
    Browse the repository at this point in the history

  10. Reinitalize Metas for every item

    @cari-lynn @jtigger
    cari-lynn authored and jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    05a328a View commit details
    Browse the repository at this point in the history

  11. Fit and finish from review 

    - extract meta type names as constants
- fix slice append gotcha: when creating a new slice, copy from old
  first (i.e. copyAndAppendMeta())
- various renames and inlining to improve clarity
    @jtigger
    jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    1ad081d View commit details
    Browse the repository at this point in the history

  12. Use a custom definition of equal ImageOverrides 

    - meta are descriptive, not identifying, so they have no bearing on
  whether two ImageOverrides are equal.

Given that all overrides are created brand fresh during a resolve for
the kbld lock file, there's no need to dedup them (removed call to
UniqueImageOverride()).
    @jtigger
    jtigger committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    2c48ce6 View commit details
    Browse the repository at this point in the history