Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH is deprecating Node.js 16 actions. Upgrade to Node 20 needed #299

Closed
ThomasVitale opened this issue Sep 24, 2023 · 0 comments · Fixed by #300
Closed

GH is deprecating Node.js 16 actions. Upgrade to Node 20 needed #299

ThomasVitale opened this issue Sep 24, 2023 · 0 comments · Fixed by #300

Comments

@ThomasVitale
Copy link
Contributor

When using the carvel-setup-action, from October 23rd, GitHub will start producing a message warning about the future deprecation (Spring 2024) of any Node.js 16 actions due to the fact that Node 16 has reached end of life.

GitHub recommends maintainers to start migrating their actions to Node 20.

More information: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
@ThomasVitale ThomasVitale changed the title GH is deprecating Node.js 16 actions. Upgrade to Node >= 20 needed GH is deprecating Node.js 16 actions. Upgrade to Node 20 needed Sep 24, 2023
@ThomasVitale ThomasVitale mentioned this issue Sep 24, 2023
Merged
jbrunton pushed a commit that referenced this issue Sep 26, 2023
@ThomasVitale
Upgrade Node 16 to Node 20 (#300)
a173dc9 
* Upgrade Node 16 to Node 20

Fixes gh-299

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>

* Migrate from @zeit/ncc to @vercel/ncc

The @zeit/ncc library is no longer maintained
and doesn't support Node 20.
Migrating to @vercel/ncc is recommended.

Fixes gh-299

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>

* Update package-lock file

Re-generate package-lock file after migrating
from @zeit/ncc to @vercel/ncc

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>

* Update index.js

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>

* fix: specific version e2e test

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>

---------

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@ThomasVitale ThomasVitale mentioned this issue Apr 14, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Node 16 to Node 20
1 participant
@ThomasVitale