Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unix-specific logging path #36

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix unix-specific logging path #36

merged 3 commits into from
Sep 26, 2023

Conversation

paaanic
Copy link
Contributor

@paaanic paaanic commented Sep 4, 2023

This PR provides several enhancements:

Closes #29

@paaanic
Add CI tests
267ed6d 
Signed-off-by: panic <speshilovmax@gmail.com>
@paaanic
Fix kapp.Diff errorf args
8f41787 
Signed-off-by: panic <speshilovmax@gmail.com>
@paaanic
Replace unix-specific /tmp path with os.TempDir
488637f 
Signed-off-by: panic <speshilovmax@gmail.com>
joaopapereira
joaopapereira approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit d24769b into carvel-dev:develop Sep 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopapereira joaopapereira joaopapereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider writes logging to disk — in a Unix-specific way (doesn't work on Windows)
2 participants
@paaanic @joaopapereira