Merge pull request #360 from meier-christoph/patch-1

fix: close tmp file before rename
carvel-dev · Feb 20, 2024 · 498f554 · 498f554
2 parents f7c3651 + 728e3d4
commit 498f554
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/vendir/fetch/http/sync.go b/pkg/vendir/fetch/http/sync.go
@@ -38,16 +38,17 @@ func (t *Sync) Sync(dstPath string, tempArea ctlfetch.TempArea) (ctlconf.LockDir
 		return lockConf, err
 	}
 
-	defer tmpFile.Close()
 	defer os.Remove(tmpFile.Name())
 
 	err = t.downloadFileAndChecksum(tmpFile)
 	if err != nil {
+		tmpFile.Close()
 		return lockConf, fmt.Errorf("Downloading URL: %s", err)
 	}
 
 	incomingTmpPath := filepath.Dir(tmpFile.Name())
 	archivePath := filepath.Join(incomingTmpPath, path.Base(t.opts.URL))
+	tmpFile.Close()
 	err = os.Rename(tmpFile.Name(), archivePath)
 	if err != nil {
 		return lockConf, err