Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue on page /development.html #333

Closed
henrydingliu opened this issue Aug 28, 2022 · 2 comments
Closed

Issue on page /development.html #333

henrydingliu opened this issue Aug 28, 2022 · 2 comments
Labels
Documentation

Comments

@henrydingliu
Copy link
Collaborator

there is a note on this page that says

drop_high and drop_low are ignored in cases where the number of link ratios available for a given development period is less than 3.

the default value for preserve seems to be 1, not 3. not sure if this is a documentation error or the documentation actually reflects the original intent.
@kennethshsu
Copy link
Collaborator

That's right, preserve is a new variable, it used to be set to 3 and wasn't modifiable, but now preserve can be set by the user.

This documentation needs to be updated.

kennethshsu added a commit that referenced this issue Sep 30, 2022
@kennethshsu
addressed #319 and #333
971d504
@kennethshsu kennethshsu mentioned this issue Sep 30, 2022
Merged
jbogaardt added a commit that referenced this issue Sep 30, 2022
@jbogaardt
Merge pull request #338 from casact/annual_meeting_prep
a3b0e22 
addressed #319 and #333
@kennethshsu
Copy link
Collaborator

This is now resolved, closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kennethshsu @henrydingliu