Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable caching when testing sandbox preview SDKs #1211

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Disable caching when testing sandbox preview SDKs #1211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,11 @@ class PaparazziPluginTest {
fun buildClassNextSdkAccess() {
val fixtureRoot = File("src/test/projects/build-class-next-sdk")

// Paparazzi detects Android platform dir contents to be static. Therefore, it re-runs only on
// compileSdk changes. Sandbox previews are an exception, so let's disable caching for this
// test task.
gradleRunner
.withArguments("testDebug", "--stacktrace")
.withArguments("testDebug", "-Dorg.gradle.caching=false", "--stacktrace")
.runFixture(fixtureRoot) { build() }

val snapshotsDir = File(fixtureRoot, "custom/reports/paparazzi/debug/images")
Expand Down
6 changes: 3 additions & 3 deletions ...jects/build-class-next-sdk/src/test/java/app/cash/paparazzi/plugin/test/BuildClassTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class BuildClassTest {

@Test
fun verifyFields() {
assertThat(Build.ID).isEqualTo("URD9.230712.002.A1")
assertThat(Build.DISPLAY).isEqualTo("sdk_phone_armv7-userdebug UpsideDownCakePrivacySandbox URD9.230712.002.A1 10628788 test-keys")
assertThat(Build.DISPLAY).isEqualTo("sdk_phone_armv7-userdebug UpsideDownCakePrivacySandbox URD9.231106.004.A2 11164158 test-keys")
assertThat(Build.ID).isEqualTo("URD9.231106.004.A2")
assertThat(Build.PRODUCT).isEqualTo("unknown")
assertThat(Build.DEVICE).isEqualTo("generic")
assertThat(Build.BOARD).isEqualTo("unknown")
Expand All @@ -43,7 +43,7 @@ class BuildClassTest {
assertThat(Build.SKU).isEqualTo("unknown")
assertThat(Build.ODM_SKU).isEqualTo("unknown")

assertThat(Build.VERSION.INCREMENTAL).isEqualTo("10628788")
assertThat(Build.VERSION.INCREMENTAL).isEqualTo("11164158")
assertThat(Build.VERSION.RELEASE).isNotNull()
assertThat(Build.VERSION.RELEASE_OR_CODENAME).isNotNull()
assertThat(Build.VERSION.BASE_OS).isEqualTo("")
Expand Down