-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 api #110
V1 api #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I would like to do some manual testing before merge
This PR still lacks passing the unit='usd' to getMintQuote. Do you want to update after v1 is merged? |
yes |
Still waiting for this to get merged into dev branch before I can make changes for unit=usd. |
I'm going to one more thing before the merge: cashubtc/nuts#93 |
Nutshell integration tests in f46001b are failing because the token state check with |
I was doing some more reviewing and there will be some more changes coming. |
I think this is ready for merge. Did more testing with nutstash wallet, and everything seems to work as expected. @callebtc @starbackr-dev |
LGTM 🚀 |
Updates to the V1 API in Cashu-TS.
Todo:
GET /v1/info
GET /v1/keys
GET /v1/keys/{keyset_id}
GET /v1/keysets
GET /v1/check
POST /v1/split
POST /v1/melt/quote/bolt11
POST /v1/melt/bolt11
POST /v1/mint/quote/bolt11
POST /v1/mint/bolt11
BlindedMessage
now hasid
fieldOut of scope:
Implement keyset ID derivation. Right now, it simply trusts the mint to respond with the correct keyset ID