Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 api #110

Merged
merged 67 commits into from
Mar 25, 2024
Merged

V1 api #110

merged 67 commits into from
Mar 25, 2024

Conversation

callebtc
Copy link
Contributor

@callebtc callebtc commented Feb 26, 2024

Updates to the V1 API in Cashu-TS.

Todo:

  • Implement all v1 endpoints and models
    • GET /v1/info
    • GET /v1/keys
    • GET /v1/keys/{keyset_id}
    • GET /v1/keysets
    • GET /v1/check
    • POST /v1/split
    • POST /v1/melt/quote/bolt11
    • POST /v1/melt/bolt11
    • POST /v1/mint/quote/bolt11
    • POST /v1/mint/bolt11
  • BlindedMessage now has id field
  • Use 64-char hex string for generating secrets
  • Update tests to new hex keyset IDs and secrets
  • Add Nutshell mint end-to-end integration tests (Docker pipeline not working yet, but tests are green)

Out of scope:
Implement keyset ID derivation. Right now, it simply trusts the mint to respond with the correct keyset ID

@callebtc callebtc marked this pull request as ready for review February 26, 2024 11:39
gandlafbtc
gandlafbtc previously approved these changes Feb 27, 2024
Copy link
Collaborator

@gandlafbtc gandlafbtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I would like to do some manual testing before merge

@starbackr-dev
Copy link
Contributor

This PR still lacks passing the unit='usd' to getMintQuote. Do you want to update after v1 is merged?

@gandlafbtc
Copy link
Collaborator

yes

@gandlafbtc gandlafbtc mentioned this pull request Feb 29, 2024
6 tasks
@starbackr-dev
Copy link
Contributor

Still waiting for this to get merged into dev branch before I can make changes for unit=usd.

@callebtc
Copy link
Contributor Author

callebtc commented Mar 7, 2024

I'm going to one more thing before the merge: cashubtc/nuts#93

@callebtc
Copy link
Contributor Author

callebtc commented Mar 7, 2024

Nutshell integration tests in f46001b are failing because the token state check with Y has not been released in nutshell yet. Need to think about how to synchronize this best.

@gandlafbtc
Copy link
Collaborator

I was doing some more reviewing and there will be some more changes coming.

@gandlafbtc gandlafbtc dismissed their stale review March 20, 2024 00:42

needs more changes

@gandlafbtc
Copy link
Collaborator

gandlafbtc commented Mar 24, 2024

I think this is ready for merge. Did more testing with nutstash wallet, and everything seems to work as expected. @callebtc @starbackr-dev

@callebtc
Copy link
Contributor Author

LGTM 🚀

@gandlafbtc gandlafbtc merged commit ef13d93 into development Mar 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants