Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getTermCountsWithAnalyzer when term has a colon in it #1135

Merged
merged 1 commit into from
May 2, 2020

Conversation

lintool
Copy link
Member

@lintool lintool commented May 2, 2020

Previous use of parser means that a term with a colon is interpreted as a field. See castorini/pyserini#81

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #1135 into master will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1135      +/-   ##
============================================
+ Coverage     47.54%   47.75%   +0.20%     
- Complexity      699      706       +7     
============================================
  Files           143      143              
  Lines          8280     8278       -2     
  Branches       1180     1180              
============================================
+ Hits           3937     3953      +16     
+ Misses         4006     3988      -18     
  Partials        337      337              
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/anserini/index/IndexReaderUtils.java 45.35% <100.00%> (-0.60%) 21.00 <2.00> (ø)
...anserini/ltr/feature/base/PMIFeatureExtractor.java 86.53% <0.00%> (+1.92%) 13.00% <0.00%> (+1.00%)
...java/io/anserini/ltr/feature/CountBigramPairs.java 87.01% <0.00%> (+22.07%) 29.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380d22b...33c7e3c. Read the comment docs.

Copy link
Contributor

@PepijnBoers PepijnBoers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit solves my issue in Pyserini.

@lintool lintool merged commit d75f39c into master May 2, 2020
@lintool lintool deleted the indexutils-patch branch May 2, 2020 14:03
crystina-z pushed a commit to crystina-z/anserini that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants