Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append to MS MARCO reproduction logs #1712

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Append to MS MARCO reproduction logs #1712

merged 1 commit into from
Dec 30, 2021

Conversation

tyao-t
Copy link
Contributor

@tyao-t tyao-t commented Dec 19, 2021

@lintool Please review. I have reproduced the experiments.

@lintool
Copy link
Member

lintool commented Dec 27, 2021

@tyao-t I assume everything checked out? Can you please explicitly state so and describe your environment? Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #1712 (ffe84a8) into master (6500560) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1712   +/-   ##
=========================================
  Coverage     57.58%   57.58%           
  Complexity     1032     1032           
=========================================
  Files           173      173           
  Lines          9781     9781           
  Branches       1344     1344           
=========================================
  Hits           5632     5632           
  Misses         3675     3675           
  Partials        474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6500560...ffe84a8. Read the comment docs.

@tyao-t
Copy link
Contributor Author

tyao-t commented Dec 30, 2021

@tyao-t I assume everything checked out? Can you please explicitly state so and describe your environment? Thanks!

@lintool By "everything" you mean?
I've done all experiments in https://github.com/castorini/anserini/blob/master/docs/experiments-msmarco-passage.md and https://github.com/castorini/anserini/blob/master/docs/experiments-msmarco-doc.md

Below was my environment.
Screen Shot 2021-12-29 at 21 28 54
Screen Shot 2021-12-29 at 21 29 41

@lintool lintool merged commit c3e14dc into castorini:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants