Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receive_timeout to RyobiWebSocket ws_connect to fix issues with dropped connections #63

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

CJOWood
Copy link
Contributor

@CJOWood CJOWood commented Mar 20, 2024

Proposed change

Fixes an issue where the aiohttp library websocket connection seems to silently drop out, only throwing an exception once a command has been attempted. receive_timeout should ensure we get a response from Ryobi's server within the currently set 5 minutes. This may not be an ideal value and is an estimate based on another library's fix for the same/similar issue (they have implemented aiohttp slightly differently).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an this integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This PR is likely related to (external library) issue:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • The code has been formatted using Black (black --fast custom_components)

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README.md

@catduckgnaf catduckgnaf merged commit 146f6a8 into catduckgnaf:main Mar 20, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants