Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for Android 10+ #158

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

lehenry
Copy link

@lehenry lehenry commented Dec 12, 2020

Use background color in splash screen,
Add force dark allowed for Android API 29+ (follows the user theme)
Night color scheme for 'light blue' to fix row dividers
Screenshot_1607779471
Screenshot_1607779734

…android 29+, night color scheme for 'light blue' to fix row dividers
@Kaligula0
Copy link
Contributor

Great idea! 👌 🤩 Is it difficult to make it Android 9+? 🤔

@lehenry
Copy link
Author

lehenry commented Dec 12, 2020

@Kaligula0 yes, it would be a bit more complicated, with Android 10, there is no need for a specific setting, there is a system flag for the dark mode, and I didn't wrote a full theme, the dark mode convert (almost) all colors by itself. I took the lazy path 😉

@erikhuizinga
Copy link

I'd stick with dark mode for the more recent Android versions only, as usage of older versions than Android 10 should be limited and declining. Furthermore, it keeps this PR simple.

@Kaligula0
Copy link
Contributor

@erikhuizinga I know, I know… I just love dark mode but my phone development finished on Android 9 🤷
Nevertheless I am definitively for that Pull request!

@erikhuizinga
Copy link

It can always be be developed for Android <= 9 (by you? 😉) after this PR is accepted.

@Kaligula0
Copy link
Contributor

Is this PR still alive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants