Introduce links to CDEvents #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
xibz
force-pushed
the
links
branch
3 times, most recently
from
fc04bcf
to
ec74ada
Compare
Closed
afrittoli
reviewed
Jun 27, 2023
afrittoli
reviewed
Jun 27, 2023
afrittoli
reviewed
Jun 27, 2023
This comment was marked as outdated.
This comment was marked as outdated.
dan-han-101
reviewed
Jun 30, 2023
xibz
force-pushed
the
links
branch
2 times, most recently
from
29ac3fb
to
fb3b5e0
Compare
afrittoli
reviewed
Jul 25, 2023
afrittoli
reviewed
Jul 25, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
xibz
force-pushed
the
links
branch
2 times, most recently
from
d7f0f23
to
845e49a
Compare
elmsdata
reviewed
Aug 23, 2023
elmsdata
reviewed
Aug 23, 2023
elmsdata
reviewed
Aug 23, 2023
xibz
force-pushed
the
links
branch
2 times, most recently
from
dafe4b6
to
8c3a53e
Compare
There was a problem hiding this comment.
@xibz, please don't overwrite the old commits when doing new ones. It becomes very time consuming to review the changes when there is nothing to compare the updates towards. We will anyway squash the commits when merging the PR eventually, so there should be no problem having many commits on the PR.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
4 tasks
afrittoli
reviewed
Feb 8, 2024
xibz
force-pushed
the
links
branch
2 times, most recently
from
c2b9f37
to
83ff0cc
Compare
xibz
force-pushed
the
links
branch
6 times, most recently
from
e27639e
to
fe56c24
Compare
afrittoli
reviewed
Mar 6, 2024
afrittoli
reviewed
Mar 6, 2024
afrittoli
reviewed
Mar 6, 2024
afrittoli
reviewed
Mar 6, 2024
e-backmark-ericsson
approved these changes
Mar 11, 2024
xibz
force-pushed
the
links
branch
3 times, most recently
from
512d8f1
to
fc74d62
Compare
This commits introduces the concept of linking events to CDEvents. We take inspiration from Eiffel for certain components, and also outline new APIs and use cases. Signed-off-by: benjamin-j-powell <bjp@apple.com> Cleanup the custom spellcheck dictionary Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com> Fix linting issues Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com> Fix references to link schemas Make the references start with a / and include the whole path relative to the main schema base URL. See https://json-schema.org/understanding-json-schema/structuring#dollarref Schemas from the PR may not be published yet, so adapt the CI job to look for local files instead. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com> Fix wrong event versions Artifact packaged and artifact published had the wrong event versions. Return to v0.2.0-draft (which was already bumped in this release. Examples already match. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com> Signed-off-by: xibz <impactbchang@gmail.com>
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commits introduces the concept of linking events to CDEvents. We take inspiration from Eiffel for certain components, and also outline new APIs and use cases.
Submitter Checklist
As the author of this PR, please check off the items in this checklist: