Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possibility to create Coo and Footprint objects #130

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

szpetny
Copy link
Contributor

@szpetny szpetny commented Nov 24, 2023

Dear Matthieu,
A motivation for this is a fact that we used to rely on code which is currently not exposed in Aladin Lite v3 anymore.
And as a workaround some time ago in the email conversation you proposed to add these new APIs.
If it is still possible, adding this would be very helpful for us :)

@szpetny
Copy link
Contributor Author

szpetny commented Nov 24, 2023

I am not sure why it failed..

@bmatthieu3
Copy link
Collaborator

Hi @szpetny ,
Thank you again for your many contributions. Let me merge it. Apart from that, was there any other things to be added in the API that we discussed in that mail ? I remember about HEALPix basic methods but suggested you to use https://www.npmjs.com/package/@fxpineau/healpix

Rethinking about that, I am not against exposing a A.utils.hpxHash and A.utils.hpxCenter basic methods in the Aladin Lite api. @tboch what do you think about that ? @szpetny would you only need those 2 basic Healpix methods or do you need more other methods ?

@bmatthieu3 bmatthieu3 merged commit ede4822 into cds-astro:develop Nov 29, 2023
1 check passed
@tboch
Copy link
Collaborator

tboch commented Nov 29, 2023

Rethinking about that, I am not against exposing a A.utils.hpxHash and A.utils.hpxCenter basic methods in the Aladin Lite api. @tboch what do you think about that ? @szpetny would you only need those 2 basic Healpix methods or do you need more other methods ?

I'm not against exposing a small set of HEALPix methods, but we have to draw the line somewhere, otherwise it is certainly better to directly use the library @bmatthieu3 is mentioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants