fix: also add style sheet in shadow dom context #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.css in js inside the aladin lite div container
bmatthieu3
force-pushed
the
add-style-also-in-shadow-dom-context
branch
from
695f3f9
to
cbfe278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to cds-astro/ipyaladin#113 and marimo-team/marimo#2106 where it was identified that we don't incorporate the CSS when the widget is in a shadow DOM.
It is not tested: to be discussed when everyone is back from holidays
(also, is it the best way to grab the div? Looks ugly)