Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined ModelAladin issue #37

Merged
merged 19 commits into from
Nov 29, 2022
Merged

Fix undefined ModelAladin issue #37

merged 19 commits into from
Nov 29, 2022

Conversation

bmatthieu3
Copy link
Collaborator

This seems to work now on my python 3.8.9
What has been done:

  • I changed the version of @jupyter-widgets/base to 6 in package json
  • I updated the webpack.config.js so that it works with recent webpack version. There is now npm run build and prepublish commands that bundle the extension in ipyaladin/static (build for dev, prepublish for prod)
  • We use modern js to define classes and export (I find it more readable)

This may be linked to: #36

Follow the cookiecutter pattern to create a notebook widget
5e7c291 
Please check this link for more info: https://github.com/jupyter-widgets/widget-cookiecutter
It seems the ModelAladin undefined issue when creating an ipyaladin.Aladin instance does not longer
exist for Python 3.8.9. The work is still in progress...
@bmatthieu3 bmatthieu3 force-pushed the fix-model-aladin branch 9 times, most recently from bdd04ff to a795a97 Compare November 28, 2022 13:20
@bmatthieu3
Copy link
Collaborator Author

I merge that as it seems to work for python 3.8-x (checked on binder)

@bmatthieu3 bmatthieu3 merged commit 0a5eaa4 into cds-astro:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bmatthieu3