Pending tests should be printed when running under XCTest #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the pending tests, although not executed, will still be given to the reporter, so the pending test summary info can be printed. Note that the pending tests aren't exposed to the XCTest runner at all.
|
@pivotal-misa-sakamoto I encountered this issue most recently with you, it would be great if you could give it a try and see if it resolves the issue of pending tests not being reflected in the summary output. Same goes for @idoru and @tjarratt if you've got test bundle projects going right now :) |
tjarratt
changed the title
|
Sorry this sat here so long; I finally had some spare time to test it out today. I didn't see any reason not to merge this, since our lack of reporting pending tests has been broken for a long time (#303). |
idoru
added a commit
that referenced
this pull request
Mar 22, 2016
Pending tests should be printed when running under XCTest
|
LOL totally hamfisted that. Merged anyway since the checks had passed previously before I accidentally closed the PR. Thanks for the fixing this, @briancroom |
|
👍 Thanks for taking a look and doing the honors @idoru! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the way that Cedar integrates with the XCTest runner such that pending tests aren't ignored entirely, but are still made known to the example reporters. This results in the pending test count and summary info being included in Cedar's test output. The pending tests aren't exposed to XCTest, however, since there is no way to represent the "pending" state in its framework.
This addresses #303 and https://www.pivotaltracker.com/story/show/99707426.
(Inspired by a recent conversation with @pivotal/team-cedar, I also swapped the ad-hoc Cedar fake in
CDRXCTestSuiteSpecwith a full-fledged test double class.)