Add support for SYCL 2020 accessor constructors along with new enums #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 31, 2021
fknorr
reviewed
May 31, 2021
fknorr
reviewed
May 31, 2021
fknorr
reviewed
May 31, 2021
include/buffer.h
Outdated
| return detail::make_device_accessor<DataT, Dims, Mode>(live_cgh.get_eventual_sycl_cgh(), sr, access_info.buffer, access_info.offset); | ||
| } | ||
| template <cl::sycl::access_mode Mode, cl::sycl::target Target, typename Functor> | ||
| auto get_access(handler& cgh, Functor rmfn) const { |
fknorr
reviewed
May 31, 2021
|
|
||
| #if WORKAROUND_COMPUTECPP | ||
| template <cl::sycl::access_mode Mode, cl::sycl::access::target Trgt, typename Functor> | ||
| auto get_access(handler& cgh, Functor rmfn) const { |
There was a problem hiding this comment.
We're keeping this deduced return type because we would otherwise implement some additional translation for cl::sycl::access::target, and this workaround is temporary anyway.
There was a problem hiding this comment.
We're keeping this deduced return type because we would otherwise implement some additional translation for cl::sycl::access::target, and this workaround is temporary anyway.
fknorr
reviewed
May 31, 2021
include/ccpp_adapt.h
Outdated
| @@ -0,0 +1,63 @@ | |||
|
|
|||
There was a problem hiding this comment.
Is there a more expressive name for this header file?
There was a problem hiding this comment.
renamed to ccpp_2020_compatibility_layer.h
psalz
reviewed
May 31, 2021
|
I just noticed that the |
psalz
force-pushed
the
feature/sycl2020/accessor-initialization
branch
from
c1225f1
to
2b674f1
Compare
facuMH
force-pushed
the
feature/sycl2020/accessor-initialization
branch
from
2b674f1
to
a2d9a76
Compare
along with new enums for modes/targets and deduction from new tags. A file for compatibility with ComputeCpp 2.5.0 was added since they do not provide support for some of the features of SYCL 2020 we are using. matmul, wave_sim and syncing examples were updated to the new accessor constructor syntax.
facuMH
force-pushed
the
feature/sycl2020/accessor-initialization
branch
from
88faba5
to
001697e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Celerity supports many implementations of SYCL and they each have a different degree of support for the SYCL 2020 functionalities, in this first approach I intend to introduce to our users a new option for instantiating accessors, using the new Tags to specify Mode and Target.
A compatibility layer had to be implemented for ComputeCpp since they have not yet implemented some enums and types needed to provide this new functionalities to our users.