Fix SYCL accessor subrange calculation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fknorr
force-pushed
the
fix-sycl-accessor-sr
branch
3 times, most recently
from
f48d112
to
0e28244
Compare
fknorr
force-pushed
the
fix-sycl-accessor-sr
branch
from
0e28244
to
5ee67ca
Compare
|
LGTM! |
psalz
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset and ranges we used to construct SYCL accessors were incorrect since #33. This did not manifest in the tests as the SYCL implementations we test with do not assert their correctness. This PR corrects these ranges and adds a regression test.