Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodebuilder/swamp/tests: Add test for bootstrapping from previously-seen peers #2506

Open
renaynay opened this issue Jul 21, 2023 · 0 comments
Open

nodebuilder/swamp/tests: Add test for bootstrapping from previously-seen peers #2506

renaynay opened this issue Jul 21, 2023 · 0 comments
Assignees
@renaynay
Labels
area:p2p good first issue Good for newcomers kind:testing Related to unit tests swamp Related to Integration tests

Comments

@renaynay
Copy link
Member

No description provided.

@renaynay renaynay added area:p2p swamp Related to Integration tests labels Jul 21, 2023
@renaynay renaynay self-assigned this Jul 21, 2023
@renaynay renaynay mentioned this issue Jul 21, 2023
Merged
renaynay added a commit that referenced this issue Sep 5, 2023
@renaynay
feat(nodebuilder/header): Bootstrap from previously seen peers (#2507)
c146a0a 
Provides `PIDStore` to header module so that it can be used in
`peerTracker` and replaces mem `peerstore.Peerstore` with on-disk
`peerstore.Peerstore` so that `peerTracker` can quickly bootstrap itself
with previously-seen peers and allow syncer to initialise its sync
target from tracked peers rather than trusted so long as it has a
subjective head within the trusting period.

Overrides #2133 

Closes #1851, mitigates issues resulting from #1623

Swamp integration tests to follow (tracked in #2506)

### Future note: 

This PR introduces a soon-to-be deprecated feature from libp2p (on-disk
peerstore). Once libp2p deprecates and removes this feature, the
PIDStore will have to become a PeerAddrStore such that it can save addr
info of good peers to disk instead of just their IDs.
@ramin ramin added the kind:testing Related to unit tests label Dec 18, 2023
@ramin ramin added the good first issue Good for newcomers label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renaynay renaynay

Labels
area:p2p good first issue Good for newcomers kind:testing Related to unit tests swamp Related to Integration tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramin @renaynay