fix(header/p2p): add trivial retrying for trustedPeer requested #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
+ Coverage 54.91% 54.93% +0.02%
==========================================
Files 231 231
Lines 14999 15008 +9
==========================================
+ Hits 8236 8244 +8
- Misses 5882 5883 +1
Partials 881 881
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vgonkivs
previously approved these changes
Jan 26, 2023
renaynay
reviewed
Jan 27, 2023
3 tasks
renaynay
previously approved these changes
Jan 30, 2023
Wondertan
force-pushed
the
hlib/retry-headerex
branch
from
1fd8965
to
9182524
Compare
renaynay
previously approved these changes
Jan 31, 2023
walldiss
reviewed
Jan 31, 2023
walldiss
previously approved these changes
Jan 31, 2023
walldiss
approved these changes
Jan 31, 2023
renaynay
approved these changes
Jan 31, 2023
renaynay
pushed a commit
that referenced
this pull request
Jan 31, 2023
Anyway, we should have a retry mechanism for requests here(but long term, it should be better than this implementation), and also, this is helping with #1623 during the first initialization of a node.
renaynay
pushed a commit
that referenced
this pull request
Feb 1, 2023
Anyway, we should have a retry mechanism for requests here(but long term, it should be better than this implementation), and also, this is helping with #1623 during the first initialization of a node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyway, we should have a retry mechanism for requests here(but long term, it should be a better than this implementation), and also, this seems to be helping with #1623 during the first initialization of a node.