fix(share/discovery): add loop to read events from the channel multiple times #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1684 +/- ##
=======================================
Coverage 55.05% 55.05%
=======================================
Files 231 231
Lines 15032 15033 +1
=======================================
+ Hits 8276 8277 +1
Misses 5874 5874
Partials 882 882
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
walldiss
approved these changes
Feb 2, 2023
Wondertan
approved these changes
Feb 2, 2023
Wondertan
pushed a commit
that referenced
this pull request
Feb 2, 2023
vgonkivs
added a commit
to vgonkivs/celestia-node
that referenced
this pull request
Feb 2, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Feb 2, 2023
renaynay
added a commit
that referenced
this pull request
Feb 8, 2023
As #1684 resolves instability with our bootstrappers, we no longer need to depend on @Wondertan's fork of libp2p Related to #1623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #1683
Checklist