Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edsstore): close files after Put and Get #1994

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix(edsstore): close files after Put and Get #1994

merged 1 commit into from
Mar 31, 2023

Conversation

distractedm1nd
Copy link
Collaborator

Self explanatory

@distractedm1nd distractedm1nd added area:shares Shares and samples kind:fix Attached to bug-fixing PRs labels Mar 31, 2023
@distractedm1nd distractedm1nd self-assigned this Mar 31, 2023
Wondertan
Wondertan approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel embarrassed, but glad we found it

renaynay
renaynay approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof

@distractedm1nd distractedm1nd merged commit f18b1ab into celestiaorg:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@distractedm1nd distractedm1nd

Labels
area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@distractedm1nd @Wondertan @renaynay