feat(store/mem_file): add in-memory eds file implementation #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
ramin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## protocol_v2 #2992 +/- ##
==============================================
Coverage ? 50.98%
==============================================
Files ? 169
Lines ? 11078
Branches ? 0
==============================================
Hits ? 5648
Misses ? 4919
Partials ? 511 ☔ View full report in Codecov by Sentry. |
Wondertan
reviewed
Dec 6, 2023
| @@ -73,15 +73,15 @@ func (ns NamespacedShares) Verify(root *Root, namespace Namespace) error { | |||
|
|
|||
| for i, row := range ns { | |||
| // verify row data against row hash from original root | |||
| if !row.verify(originalRoots[i], namespace) { | |||
| if !row.Verify(originalRoots[i], namespace) { | |||
There was a problem hiding this comment.
A minor change from local changes. It makes sure we don't segfault when proof is malformed.
Suggested change
| if !row.Verify(originalRoots[i], namespace) { | |
| if row.Proof == nil && row.Shares == nil { | |
| return fmt.Errorf("row verification failed: no proofs and shares") | |
| } | |
| if !row.Verify(originalRoots[i], namespace) { |
Comment on lines
+56
to
+81
| bserv := ipld.NewMemBlockservice() | ||
| batchAdder := ipld.NewNmtNodeAdder(context.TODO(), bserv, ipld.MaxSizeBatchOption(len(shares))) | ||
| tree := wrapper.NewErasuredNamespacedMerkleTree(uint64(len(shares)/2), uint(rowIdx), | ||
| nmt.NodeVisitor(batchAdder.Visit)) | ||
| for _, shr := range shares { | ||
| err := tree.Push(shr) | ||
| if err != nil { | ||
| return share.NamespacedRow{}, err | ||
| } | ||
| } | ||
|
|
||
| root, err := tree.Root() | ||
| if err != nil { | ||
| return share.NamespacedRow{}, err | ||
| } | ||
|
|
||
| err = batchAdder.Commit() | ||
| if err != nil { | ||
| return share.NamespacedRow{}, err | ||
| } | ||
|
|
||
| cid := ipld.MustCidFromNamespacedSha256(root) | ||
| row, proof, err := ipld.GetSharesByNamespace(context.TODO(), bserv, cid, namespace, len(shares)) | ||
| if err != nil { | ||
| return share.NamespacedRow{}, err | ||
| } |
There was a problem hiding this comment.
We might want to dedup this later
Comment on lines
+92
to
+101
| func (f *MemFile) axis(axisType rsmt2d.Axis, axisIdx int) []share.Share { | ||
| switch axisType { | ||
| case rsmt2d.Row: | ||
| return f.Eds.Row(uint(axisIdx)) | ||
| case rsmt2d.Col: | ||
| return f.Eds.Col(uint(axisIdx)) | ||
| default: | ||
| panic("unknown axis") | ||
| } | ||
| } |
There was a problem hiding this comment.
I want this to be an rsmt2d method so bad
| ) | ||
|
|
||
| func TestMemFileShare(t *testing.T) { | ||
| eds := edstest.RandEDS(t, 32) |
There was a problem hiding this comment.
kind big for the test but doesn't really matter
share/store/mem_file_test.go
Outdated
Comment on lines
59
to
73
| rand := mrand.New(mrand.NewSource(time.Now().UnixNano())) | ||
|
|
||
| // choose random range in shares slice and set namespace to be the same for all shares in range | ||
| from := rand.Intn(size * size) | ||
| to := rand.Intn(size * size) | ||
| if to < from { | ||
| from, to = to, from | ||
| } | ||
| expected := shares[from] | ||
| namespace := share.GetNamespace(expected) | ||
|
|
||
| // change namespace for all shares in range | ||
| for i := from; i <= to; i++ { | ||
| shares[i] = expected | ||
| } |
There was a problem hiding this comment.
I would leave a todo to make this a helper. I have tests where I need something similar
There was a problem hiding this comment.
I've extracted it to test pkg in last commit for you 🙂
- extract namespace data test function
Wondertan
approved these changes
Dec 6, 2023
walldiss
added a commit
that referenced
this pull request
May 8, 2024
Adds in-memory file implementation
walldiss
added a commit
that referenced
this pull request
Jun 10, 2024
Adds in-memory file implementation
walldiss
added a commit
that referenced
this pull request
Jun 10, 2024
Adds in-memory file implementation
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Jul 6, 2024
…org#2992) Adds in-memory file implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in-memory file implementation