Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validating proper input for submit CLI #3088

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: validating proper input for submit CLI #3088

wants to merge 6 commits into from

Conversation

moldis
Copy link
Contributor

@moldis moldis commented Jan 10, 2024 •
edited
Loading

Closes #3082

  • Using existing cmdnode.DecodeToBytes to validate blob input, if not valid will use just as string input
  • Added minor unit-testing for cmdnode.DecodeToBytes, even it has been tested under Test_parseNamespaceID, it's good to have it separately since Test_parseNamespaceID has it's own logic besides DecodeToBytes

@github-actions github-actions bot added the external Issues created by non node team members label Jan 10, 2024
@moldis moldis marked this pull request as ready for review January 10, 2024 15:36
@Drewsapple Drewsapple mentioned this pull request Jan 10, 2024
Closed
@ramin ramin added the kind:fix Attached to bug-fixing PRs label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@ramin ramin Awaiting requested review from ramin

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
external Issues created by non node team members kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to upload pre-encoded (base64/hex) blobs
4 participants
@moldis @Wondertan @ramin @nodersteam