feat(share/eds) Add Accessor test infra #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
ramin
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3425 +/- ##
========================================
Coverage ? 43.61%
========================================
Files ? 287
Lines ? 16578
Branches ? 0
========================================
Hits ? 7231
Misses ? 8508
Partials ? 839 ☔ View full report in Codecov by Sentry. |
walldiss
changed the title
walldiss
changed the title
|
Linter complains |
|
Linter complains, because it is older version of linter in ci. Fixed to satisfy ci linter |
This was referenced Jun 10, 2024
walldiss
force-pushed
the
shwap
branch
4 times, most recently
from
c4550bf
to
60e757e
Compare
Wondertan
reviewed
Jun 10, 2024
cristaloleg
reviewed
Jun 10, 2024
Wondertan
approved these changes
Jun 10, 2024
walldiss
added a commit
that referenced
this pull request
Jun 17, 2024
Adds middleware to protect AccessorCloser from multiple Closes. Based on #3425
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Jul 6, 2024
Adds generalised testing framework for file interface implementaions Also adds non-inclusion proofs handling in RowNamespaceDataFromShares and closes celestiaorg#3428
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Jul 6, 2024
Adds middleware to protect AccessorCloser from multiple Closes. Based on celestiaorg#3425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds generalised testing framework for file interface implementaions
Also adds non-inclusion proofs handling in RowNamespaceDataFromShares and closes #3428