Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share/store_v2) Update file interface to use shwap types #3441

Merged
merged 2 commits into from
May 29, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented May 27, 2024

Updates file interface to latest prototype version

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 28.98551% with 49 lines in your changes are missing coverage. Please review.

Please upload report for BASE (shwap@6e9f1da). Learn more about missing BASE report.

Files Patch % Lines
share/root.go 0.00% 22 Missing ⚠️
share/store/file/mem_file.go 53.12% 15 Missing ⚠️
share/eds/utils.go 0.00% 7 Missing ⚠️
share/store/file/axis_half.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3441   +/-   ##
========================================
  Coverage         ?   43.28%           
========================================
  Files            ?      285           
  Lines            ?    16477           
  Branches         ?        0           
========================================
  Hits             ?     7132           
  Misses           ?     8499           
  Partials         ?      846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

share/store/file/axis_half.go Show resolved Hide resolved
share/ipld/get_shares.go Show resolved Hide resolved
@Wondertan
Copy link
Member

Needs rebase and PR description

@walldiss
Copy link
Member Author

Rebased

@walldiss walldiss merged commit 9e82fd6 into celestiaorg:shwap May 29, 2024
27 checks passed
walldiss added a commit that referenced this pull request Jun 10, 2024
Updates file interface to latest prototype version
walldiss added a commit that referenced this pull request Jun 10, 2024
Updates file interface to latest prototype version
walldiss added a commit to walldiss/celestia-node that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor Attached to refactoring PRs shwap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants