misc(share/p2p): reduce frequency of discovery retries #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modify in test environments in a sane way
ramin
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
cristaloleg
as code owners
walldiss
reviewed
Jul 17, 2024
renaynay
reviewed
Jul 18, 2024
Comment on lines
+62
to
+68
| if p.AdvertiseRetryTimeout <= 0 { | ||
| return fmt.Errorf("discovery: advertise retry timeout cannot be zero or negative") | ||
| } | ||
|
|
||
| if p.DiscoveryRetryTimeout <= 0 { | ||
| return fmt.Errorf("discovery: discovery retry timeout cannot be zero or negative") | ||
| } |
There was a problem hiding this comment.
Isn't this config breaking? If so, let's mark PR as such.
Wondertan
reviewed
Jul 18, 2024
… away if accidentally mistaken for a bees nest
|
There is some wisdom behind the metaphor in ca67fef, but I am not getting it |
@Wondertan ah, I put it back how it was, so no unnecessary change :-) |
|
Let's hold off on this til we get conf from v0.14.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3550 as suggested by guillaumemichel. In adjusting the "1 liner" realized there was some relatively funky stuff in tests where we set/reset a package level var for the interval, so moved both AdvertiserRetryTimeout and DiscoveryRetryTimeout to parameters and allowed customization where NewDiscovery is called. Also adjusted some of the intervals to be faster in tests so they execute within the test context Timeout and thus, hopefully will fix #3115