-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core_accessor): pass only default account for txClient #3626
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack
Also @rach-id will have to rebase his PR on this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3626 +/- ##
==========================================
+ Coverage 44.83% 45.59% +0.75%
==========================================
Files 265 281 +16
Lines 14620 16006 +1386
==========================================
+ Hits 6555 7298 +743
- Misses 7313 7870 +557
- Partials 752 838 +86 ☔ View full report in Codecov by Sentry. |
@vgonkivs actually pls wait for rachid to merge his PR, will be way way easier for u to rebase than him |
Previous version of app has a bug, so the defaultAddress had to be explicitly set. The issue is fixed in the newer release.