Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core_accessor): pass only default account for txClient #3626

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Aug 5, 2024

Previous version of app has a bug, so the defaultAddress had to be explicitly set. The issue is fixed in the newer release.

@vgonkivs vgonkivs added the kind:fix Attached to bug-fixing PRs label Aug 5, 2024
@vgonkivs vgonkivs self-assigned this Aug 5, 2024
renaynay
renaynay previously approved these changes Aug 5, 2024
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

Also @rach-id will have to rebase his PR on this

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.59%. Comparing base (2469e7a) to head (48a2c99).
Report is 152 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
+ Coverage   44.83%   45.59%   +0.75%     
==========================================
  Files         265      281      +16     
  Lines       14620    16006    +1386     
==========================================
+ Hits         6555     7298     +743     
- Misses       7313     7870     +557     
- Partials      752      838      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renaynay
Copy link
Member

renaynay commented Aug 5, 2024

@vgonkivs actually pls wait for rachid to merge his PR, will be way way easier for u to rebase than him

Wondertan
Wondertan previously approved these changes Aug 5, 2024
@renaynay renaynay added the v0.15.0 Intended for v0.15.0 release label Aug 6, 2024
@vgonkivs vgonkivs dismissed stale reviews from renaynay and Wondertan via a000aee August 6, 2024 13:43
@renaynay renaynay removed the v0.15.0 Intended for v0.15.0 release label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants