Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(state): remove defaultSignerAccount and defaultSignerAddress method #3650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kobakaku
Copy link

@kobakaku kobakaku commented Aug 12, 2024

closes #3515

  • Remove DefaultSignerAccount and defaultSignerAddress method.
  • Fix to use only the DefaultAccountAddress() function as args of SetupTxClient.

@github-actions github-actions bot added the external Issues created by non node team members label Aug 12, 2024
@kobakaku kobakaku marked this pull request as draft August 12, 2024 11:45
@kobakaku kobakaku force-pushed the remove-duplicate-default-account-address branch from 27463d3 to 6b826e6 Compare August 12, 2024 12:25
@kobakaku kobakaku changed the title chore(state): remove duplicate function chore(state): remove defaultSignerAccount and defaultSignerAddress method Aug 12, 2024
@kobakaku kobakaku marked this pull request as ready for review August 12, 2024 12:26
}
_ = user.WithDefaultAccount(keyname)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default account (& default address) needs to be updated inside NewCoreAccessor .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members
Projects
None yet
1 participant