-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/header: Add RPC endpoints to get header and DAH by height #672
Conversation
Codecov Report
@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 51.88% 51.45% -0.43%
==========================================
Files 102 103 +1
Lines 6283 6347 +64
==========================================
+ Hits 3260 3266 +6
- Misses 2682 2740 +58
Partials 341 341
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is one in JSON and the other in hex?
Good question @adlerjohn -- it's because we need the root as hex in order to do a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it would be better if all these endpoints consistently returned a JSON, even if it's just wrapping a single hex string.
@adlerjohn check the updated description and latest commit pls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
ex Exchange, | ||
rpc *rpc.Server, | ||
) *Service { | ||
serv := &Service{ | ||
syncer: syncer, | ||
sub: sub, | ||
p2pServer: p2pServer, | ||
ex: ex, | ||
} | ||
serv.RegisterEndpoints(rpc) | ||
return serv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls make registering on the Node's constructor. Like you do for ShareService and State
headerByHeightEndpoint = "/header" | ||
dahByHeightEndpoint = "/dah" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a separate /dah request if the header already contains dah? Is this an optimization that we should care rn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Optimint situation looks like:
- I need data from given namespace at given height
- I need DAH to get data by namespace
- I don't care about rest of the header
Getting only DAH is an optimization, but getting namespaced data by block height would be even better (reducing number of requests from 2 to 1) ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: After reading comments in another PR I understand why 2 requests are required (at least now).
LGTM but I defer to other engineers to approve. |
Closing in favour of #693 |
Description
This PR adds two endpoints, one to get a header by a given height and the other to get a data availability header at a given height.
The endpoints can be accessed at:
/header/{height}
/dah/{height}
Docs
GET
/header/{height}
Request
Response
GET
/dah/{height}
Request
Response