Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gingerbread Activation blocks #2180

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

gastonponti
Copy link
Contributor

@gastonponti gastonponti commented Sep 5, 2023

Description

Gingerbread Activation blocks:

Mainnet:
P1 & P2: 21616000 -> ~ 26/Sept/2023 17:15 UTC

Alfajores:
P1 & P2: 9814000 -> ~ 11/Sept/2023 17:30 UTC

Baklava:
P1: 18785000 -> 10/Aug/2023, 3:07:54 PM UTC
P2: 19157000 -> 01/Sept/2023, 2:08:22 PM UTC

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 2d25832

coverage: 47.0% of statements across all listed packages
coverage:  57.2% of statements in consensus/istanbul
coverage:  23.7% of statements in consensus/istanbul/announce
coverage:  54.3% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  65.5% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

5861 passed, 1 failed, 45 skipped

Test failures:
  TestEthersJSCompatibility: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000 denominator = 1000000000000000000000000
Checking gas price minimum. cusdValue = 100000000
executing mocha test with /usr/bin/npm run --networkaddr=http://127.0.0.1:35343 test --blocknum=0x0 -- --grep ethers.js compatibility tests with state

ethersjs-api-check@1.0.0 test /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check
mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state"

ethers.js compatibility tests with state
✔ provider.getBlock works (block has gasLimit set)
✔ EIP-1559 transactions supported (can get feeData)
✔ block has gasLimit
1) block has baseFeePerGas

3 passing (116ms)
1 failing

  1. ethers.js compatibility tests with state
    block has baseFeePerGas:

    AssertionError: expected false to be true

    • expected - actual

    -false
    +true

    at /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check/test/test.ts:52:10
    at Generator.next ()
    at fulfilled (test/test.ts:5:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ethersjs-api-check@1.0.0 test: mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ethersjs-api-check@1.0.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/runner/.npm/_logs/2023-09-05T20_16_47_985Z-debug.log

e2e_test.go:685: </code></pre></td></tr>
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07% 🎉

Comparison is base (da7fa56) 55.13% compared to head (721b5d9) 55.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2180      +/-   ##
==========================================
+ Coverage   55.13%   55.20%   +0.07%     
==========================================
  Files         678      678              
  Lines      114321   114321              
==========================================
+ Hits        63027    63108      +81     
+ Misses      47399    47331      -68     
+ Partials     3895     3882      -13     
Files Changed Coverage Δ
params/config.go 52.86% <ø> (ø)
params/version.go 30.76% <ø> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gastonponti gastonponti merged commit 2d25832 into master Sep 5, 2023
27 checks passed
@gastonponti gastonponti deleted the gastonponti/gingerbread-activation-blocks branch September 5, 2023 20:08
gastonponti added a commit that referenced this pull request Sep 5, 2023
Description
Gingerbread Activation blocks:

Mainnet:
P1 & P2: 21616000 -> ~ 26/Sept/2023 17:15 UTC

Alfajores:
P1 & P2: 9814000 -> ~ 11/Sept/2023 17:30 UTC

Baklava:
P1: 18785000 -> 10/Aug/2023, 3:07:54 PM UTC
P2: 19157000 -> 01/Sept/2023, 2:08:22 PM UTC
# Conflicts:
#	params/version.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant