Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update module golang.org/x/net to v0.23.0 [security] #2296

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 10, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
golang.org/x/net v0.17.0 -> v0.23.0 age adoption passing confidence

HTTP/2 CONTINUATION flood in net/http

BIT-golang-2023-45288 / CVE-2023-45288 / GO-2024-2687

More information

Details

An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames.

Maintaining HPACK state requires parsing and processing all HEADERS and CONTINUATION frames on a connection. When a request's headers exceed MaxHeaderBytes, no memory is allocated to store the excess headers, but they are still parsed.

This permits an attacker to cause an HTTP/2 endpoint to read arbitrary amounts of header data, all associated with a request which is going to be rejected. These headers can include Huffman-encoded data which is significantly more expensive for the receiver to decode than for an attacker to send.

The fix sets a limit on the amount of excess header frames we will process before closing a connection.

Severity

Unknown

References

This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@karlb karlb self-assigned this Apr 10, 2024
Copy link

github-actions bot commented Apr 10, 2024

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 7859a78

coverage: 50.7% of statements across all listed packages
coverage:  63.4% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  64.6% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.2% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

Copy link

github-actions bot commented Apr 10, 2024

5871 passed, 1 failed, 44 skipped

Test failures:
  TestMiner: miner

Failed
/runner/_work/celo-blockchain/celo-blockchain/consensus/consensustest/mockprotocol.go:384 +0x181

/runner/_work/celo-blockchain/celo-blockchain/miner/worker.go:466 +0xb3
/runner/_work/celo-blockchain/celo-blockchain/miner/worker.go:308 +0x515
/runner/_work/celo-blockchain/celo-blockchain/miner/worker.go:410 +0x3b
/runner/_work/celo-blockchain/celo-blockchain/miner/worker.go:409 +0x1aa

This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

Copy link
Contributor

@karlb karlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks safe and upstream also updated to the same package versions.

@karlb karlb enabled auto-merge (squash) April 10, 2024 09:42
@karlb karlb merged commit 7859a78 into master Apr 10, 2024
26 checks passed
@karlb karlb deleted the renovate/go-golang.org/x/net-vulnerability branch April 10, 2024 09:52
ezdac pushed a commit that referenced this pull request Apr 18, 2024
)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant