Split concern for pool benchmark helper #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q1-easy
lemunozm
requested review from
NunoAlexandre,
cdamian,
wischli and
mustermeiszer
lemunozm
commented
Dec 11, 2023
Comment on lines
-67
to
-82
|
|
||
| pub fn mock_bench_create_pool(f: impl Fn(T::PoolId, &T::AccountId) + 'static) { | ||
| register_call!(move |(a, b)| f(a, b)); | ||
| } | ||
|
|
||
| pub fn mock_bench_investor_setup( | ||
| f: impl Fn(T::PoolId, T::AccountId, T::Balance) + 'static, | ||
| ) { | ||
| register_call!(move |(a, b, c)| f(a, b, c)); | ||
| } | ||
|
|
||
| pub fn mock_bench_default_investment_id( | ||
| f: impl Fn(T::PoolId) -> T::TrancheCurrency + 'static + 'static, | ||
| ) { | ||
| register_call!(f); | ||
| } |
There was a problem hiding this comment.
No longer needed if mock implementation for these is empty (which makes sense because you do not want to benchmark in testing)
cdamian
previously approved these changes
Dec 11, 2023
wischli
previously approved these changes
Dec 11, 2023
mustermeiszer
previously approved these changes
Dec 11, 2023
lemunozm
dismissed stale reviews from mustermeiszer, wischli, and cdamian
via
6ab2c7c
|
Can I have a re-approval? |
cdamian
approved these changes
Dec 11, 2023
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous
PoolBenchmarkHelperutility made use of investment utilities. This forces you to track investment bounds through the code, which is ok for parts that will end to use investments, but for cases where you only want to create a pool, it is boilerplate and annoying to use, carrying information out of the problem scope. This PR splits the current trait into 2 depending on the usage you require.Changes and Descriptions
PoolBenchmarkHelpertoFundedPoolBenchmarkHelper, for creating funded pools.PoolBenchmarkHelperfor only creating just pools.Required for OracleV2. #1629