Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liquidity-pools: Ensure only pool admins can allow investment currencies #1681

Merged
merged 1 commit into from
Jan 8, 2024
Merged

liquidity-pools: Ensure only pool admins can allow investment currencies #1681

merged 1 commit into from
Jan 8, 2024

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Jan 8, 2024 •
edited
Loading

Description

Fixes #1677

Changes and Descriptions

Added a permission check for the pool admin role.

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

lemunozm
lemunozm previously approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As fast as lightning!

@cdamian cdamian force-pushed the 1677-fix-restrict-allowinvestmentcurrency-for-pooladmin branch from 8895493 to 1ea61bb Compare January 8, 2024 13:57
wischli
wischli approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so quickly!

@wischli wischli enabled auto-merge (squash) January 8, 2024 14:16
@wischli wischli merged commit c93f96f into main Jan 8, 2024
9 checks passed
@cdamian cdamian deleted the 1677-fix-restrict-allowinvestmentcurrency-for-pooladmin branch January 8, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

@lemunozm lemunozm lemunozm left review comments

@mustermeiszer mustermeiszer Awaiting requested review from mustermeiszer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: Restrict AllowInvestmentCurrency for PoolAdmin
3 participants
@cdamian @lemunozm @wischli