lp-gateway: Add queue for outbound messages #1696

cdamian · 2024-01-17T15:12:06Z

Description

Fixes #1694

Changes and Descriptions

Added storage for outbound messages.
Added on-idle hook logic for processing outbound messages.
Added DispatchResultWithPostInfo to routers for retrieving weight.
Added storage for failed outbound messages.
Added extrinsics for manually executing messages.

Checklist:

I have added Rust doc comments to structs, enums, traits and functions
I have made corresponding changes to the documentation
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works

lemunozm

LGTM!

Just a question

pallets/liquidity-pools-gateway/src/lib.rs

cdamian · 2024-01-17T19:29:14Z

pallets/liquidity-pools-gateway/routers/src/lib.rs

@@ -257,7 +253,10 @@ where
 			true,
 		)?;

-		Ok(())
+		Ok(PostDispatchInfo {
+			actual_weight: Some(self.xcm_domain.overall_weight),


The above call to transact_through_sovereign returns a normal DispatchResult, meaning that we cannot get the weight of the call. If there is another way of retrieving the weight of that call, please let me know and I will adjust.

pallets/liquidity-pools-gateway/src/lib.rs

mustermeiszer

First look.

pallets/liquidity-pools-gateway/src/lib.rs

mustermeiszer · 2024-01-18T13:10:43Z

once this is realeased: We have to re-execute https://axelarscan.io/gmp/0x15c33b374f44725927e0025a3e3b07ebb99bc844307e2563161df8de6a331ac4:11

mustermeiszer

Logic looks good! Need to check the weights again in more detail. Probably need @wischli eyes on this too!

Should we add anymore test? I would like to bring this into the next RU if possible.

gpmayorga · 2024-01-19T12:14:09Z

there was an error in the pipeline due to Gcloud permissions. It is fixed but it seems like Clippy is unhappy still

wischli

Looks really good and clean! I have one minor, pedantic change request for the weight calculation because we are introducing an inherent here were being correct is important.

Apart from that, sorry about the large list of nits which can be ignored 🫠

runtime/altair/src/liquidity_pools.rs

pallets/liquidity-pools-gateway/src/lib.rs

wischli

Thanks a lot for adhering to my pedantic nit picks 🫶. We only need to discuss the missing cleanup possibility of failure-safe messages, which IMO does not have to be part of this PR.

pallets/liquidity-pools-gateway/src/lib.rs

cdamian · 2024-01-30T10:58:05Z

pallets/liquidity-pools-gateway/src/lib.rs

+		/// `FailedOutboundMessages` storage.
+		#[pallet::weight(T::WeightInfo::process_outbound_message())]
+		#[pallet::call_index(6)]
+		pub fn process_outbound_message(


Note how we always return Ok(()) here so that we can preserve the storage changes in case of errors.

cdamian · 2024-01-30T10:58:12Z

pallets/liquidity-pools-gateway/src/lib.rs

+		/// Manually process a failed outbound message.
+		#[pallet::weight(T::WeightInfo::process_failed_outbound_message())]
+		#[pallet::call_index(7)]
+		pub fn process_failed_outbound_message(


Note how we always return Ok(()) here so that we can preserve the storage changes in case of errors.

wischli

Great test additions!

pallets/liquidity-pools-gateway/src/tests.rs

pallets/liquidity-pools-gateway/src/lib.rs

…, remove extra checks for instances

lemunozm reviewed Jan 17, 2024

View reviewed changes

pallets/liquidity-pools-gateway/src/lib.rs Outdated Show resolved Hide resolved

pallets/liquidity-pools-gateway/src/lib.rs Show resolved Hide resolved

cdamian force-pushed the 1694-feat-implement-queue-logic-for-outbound-queue branch from 3b7c6f7 to cdd9030 Compare January 17, 2024 19:27

cdamian commented Jan 17, 2024

View reviewed changes

pallets/liquidity-pools-gateway/src/lib.rs Outdated Show resolved Hide resolved

cdamian self-assigned this Jan 17, 2024

cdamian requested a review from mustermeiszer January 18, 2024 09:19

mustermeiszer reviewed Jan 18, 2024

View reviewed changes

cdamian force-pushed the 1694-feat-implement-queue-logic-for-outbound-queue branch from cdd9030 to d4f41a8 Compare January 18, 2024 14:06

mustermeiszer reviewed Jan 19, 2024

View reviewed changes

wischli added this to the Centrifuge 1025 milestone Jan 24, 2024

wischli reviewed Jan 24, 2024

View reviewed changes

cdamian force-pushed the 1694-feat-implement-queue-logic-for-outbound-queue branch from d4f41a8 to 53c3df9 Compare January 29, 2024 13:37

wischli previously approved these changes Jan 30, 2024

View reviewed changes

pallets/liquidity-pools-gateway/src/lib.rs Show resolved Hide resolved

cdamian dismissed wischli’s stale review via 27b3abe January 30, 2024 10:54

cdamian force-pushed the 1694-feat-implement-queue-logic-for-outbound-queue branch from 27b3abe to 564fb2c Compare January 30, 2024 10:56

cdamian commented Jan 30, 2024

View reviewed changes

cdamian requested review from wischli, mustermeiszer and lemunozm January 30, 2024 17:00

wischli previously approved these changes Jan 31, 2024

View reviewed changes

pallets/liquidity-pools-gateway/src/tests.rs Outdated Show resolved Hide resolved

pallets/liquidity-pools-gateway/src/tests.rs Outdated Show resolved Hide resolved

pallets/liquidity-pools-gateway/src/lib.rs Show resolved Hide resolved

cdamian added 7 commits January 31, 2024 10:38

lp-gateway: Add queue for outbound messages

805fade

primitives: Add primitive type for outbound message nonce

46ebff3

lp-gateway: Adjust weight calculations when processing outbound messages

959472d

integration-tests: Add nonce when checking success events

c6c9531

lp-gateway: Add tests for outbound message extrinsics

2661c94

integration-tests: Use correct sender when checking LP gateway events…

5750a86

…, remove extra checks for instances

lp-gateway: Remove redundant events, use get when checking storage

9245f57

cdamian dismissed wischli’s stale review via 9245f57 January 31, 2024 09:39

cdamian force-pushed the 1694-feat-implement-queue-logic-for-outbound-queue branch from be88d26 to 9245f57 Compare January 31, 2024 09:39

wischli approved these changes Jan 31, 2024

View reviewed changes

cdamian merged commit 70babe3 into main Jan 31, 2024
9 checks passed

cdamian deleted the 1694-feat-implement-queue-logic-for-outbound-queue branch January 31, 2024 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lp-gateway: Add queue for outbound messages #1696

lp-gateway: Add queue for outbound messages #1696

cdamian commented Jan 17, 2024 •

edited

Loading

lemunozm left a comment

cdamian Jan 17, 2024

mustermeiszer left a comment

mustermeiszer commented Jan 18, 2024

mustermeiszer left a comment

gpmayorga commented Jan 19, 2024

wischli left a comment •

edited

Loading

wischli left a comment

cdamian Jan 30, 2024

cdamian Jan 30, 2024

wischli left a comment

lp-gateway: Add queue for outbound messages #1696

lp-gateway: Add queue for outbound messages #1696

Conversation

cdamian commented Jan 17, 2024 • edited Loading

Description

Changes and Descriptions

Checklist:

lemunozm left a comment

Choose a reason for hiding this comment

cdamian Jan 17, 2024

Choose a reason for hiding this comment

mustermeiszer left a comment

Choose a reason for hiding this comment

mustermeiszer commented Jan 18, 2024

mustermeiszer left a comment

Choose a reason for hiding this comment

gpmayorga commented Jan 19, 2024

wischli left a comment • edited Loading

Choose a reason for hiding this comment

wischli left a comment

Choose a reason for hiding this comment

cdamian Jan 30, 2024

Choose a reason for hiding this comment

cdamian Jan 30, 2024

Choose a reason for hiding this comment

wischli left a comment

Choose a reason for hiding this comment

cdamian commented Jan 17, 2024 •

edited

Loading

wischli left a comment •

edited

Loading