Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtimes: use last benchmark structure, remove unused disable-api feature #1813

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

lemunozm
Copy link
Contributor

Description

  • Use the new way of setting a benchmarking list.
    • We no longer need an explicit whitelist. See this thread. I've tested anyways and the keys are in.
  • Remove the unused disable-runtime-api feature. (no longer used by Polkadot).

@lemunozm lemunozm added Q1-easy Can be done by primarily duplicating and adapting code. I6-refactoring Code needs refactoring. labels Apr 17, 2024
@lemunozm lemunozm self-assigned this Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.53%. Comparing base (58045f4) to head (6934d7d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
+ Coverage   48.46%   48.53%   +0.07%     
==========================================
  Files         168      167       -1     
  Lines       13332    13314      -18     
==========================================
+ Hits         6461     6462       +1     
+ Misses       6871     6852      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ding ding ding, the fixing cleanup hammer strikes again. Thanks so much!

@lemunozm
Copy link
Contributor Author

I had it in the stash, and it was time to upload it 😆

@lemunozm lemunozm enabled auto-merge (squash) April 17, 2024 12:39
@lemunozm lemunozm merged commit da63bf1 into main Apr 17, 2024
12 checks passed
@lemunozm lemunozm deleted the ref/runtimes-updated-benchmarks-apis branch April 17, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I6-refactoring Code needs refactoring. Q1-easy Can be done by primarily duplicating and adapting code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants