Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test: making it cooler! #1821

Merged
merged 8 commits into from
Apr 26, 2024
Merged

Integration test: making it cooler! #1821

merged 8 commits into from
Apr 26, 2024

Conversation

lemunozm
Copy link
Contributor

Description

#[test_runtimes([development, altair, centrifuge])]
fn foo<T: Runtime> {
    // Your test here...
}

or

#[test_runtimes(all)]
fn foo<T: Runtime> {
    // Your test here...
}

Benefits

  • It's prettier!
  • Better readability
  • We no longer confuse an utility method with the same "shape" as foo from an actual test method

@lemunozm lemunozm added I4-tests Test needs fixing or improving. P2-nice-to-have Issue is worth doing. labels Apr 23, 2024
@lemunozm lemunozm self-assigned this Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@5ab100b). Click here to learn what that means.

Files Patch % Lines
runtime/integration-tests/procedural/src/lib.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1821   +/-   ##
=======================================
  Coverage        ?   48.54%           
=======================================
  Files           ?      169           
  Lines           ?    13370           
  Branches        ?        0           
=======================================
  Hits            ?     6491           
  Misses          ?     6879           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wischli
wischli previously approved these changes Apr 23, 2024
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement 🚀

mustermeiszer
mustermeiszer previously approved these changes Apr 25, 2024
Copy link
Collaborator

@mustermeiszer mustermeiszer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lemunozm lemunozm dismissed stale reviews from mustermeiszer and wischli via 7876e37 April 25, 2024 09:56
@lemunozm lemunozm enabled auto-merge (squash) April 25, 2024 10:37
@lemunozm
Copy link
Contributor Author

@wischli @mustermeiszer @cdamian Can I have a reapproval?

Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re approving!

@lemunozm lemunozm merged commit 987aa11 into main Apr 26, 2024
12 checks passed
@lemunozm lemunozm deleted the it/test-runtimes-macro branch April 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I4-tests Test needs fixing or improving. P2-nice-to-have Issue is worth doing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants